Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo [ci skip] #15880

Merged
merged 1 commit into from
Jun 23, 2014
Merged

Small typo [ci skip] #15880

merged 1 commit into from
Jun 23, 2014

Conversation

davetoxa
Copy link
Contributor

馃槂

@zzak
Copy link
Member

zzak commented Jun 23, 2014

@davetoxa Please do a grep for all instances of 'overriden' in the source and send a patch. I don't want to merge this knowing there are others ;)

git grep 'overriden'
activerecord/lib/active_record/attributes.rb:30:      # The type detected by Active Record can be overriden.
activerecord/lib/active_record/type/value.rb:66:      # should not be overriden by subclasses. Instead, override `cast_value`.
guides/source/layouts_and_rendering.md:311:NOTE: Unless overriden, your response returned from this render option will be
guides/source/upgrading_ruby_on_rails.md:318:Default scopes are no longer overriden by chained conditions.
guides/source/upgrading_ruby_on_rails.md:321:it was overriden by chained conditions in the same field. Now it

@davetoxa
Copy link
Contributor Author

@zzak done 馃憤

zzak pushed a commit that referenced this pull request Jun 23, 2014
s/overriden/overridden [ci skip]
@zzak zzak merged commit c73f97b into rails:master Jun 23, 2014
@zzak
Copy link
Member

zzak commented Jun 23, 2014

@davetoxa Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants