Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails config for raise on missing translations #15915

Merged

Conversation

lukaszx0
Copy link
Member

If I recall correctly, it disappeared from 3-0 and was missing ever since, restored back in 4-1. This PR backports @kassio's commit from 4-1 to 4-0.

Would be great if we could pack this in 4.0.6 release.

/cc @tamird

Add a config to setup whether raise exception for missing translation or
not.

Conflicts:
	actionview/CHANGELOG.md
@sgrif
Copy link
Contributor

sgrif commented Jun 25, 2014

Seems like this is an improvement rather than a bug fix. Isn't 4.0 bugfix only?

@tamird
Copy link
Contributor

tamird commented Jun 25, 2014

Looks like a bugfix to me, in that it corrects a regression. More info: #13196

@lukaszx0
Copy link
Member Author

For me, it's very old regression which wasn't fixed.

@rafaelfranca
Copy link
Member

When I was working with @kassio on this I thought we should apply to 4-0-stable too because a security fix removed the possibility to raise on missing translation but since it doesn't work on 3.x and it is adding a new configuration I choose to not apply to 4.0.

I'm know a lot of people already requested this before so I would consider merging it but I still don't have a strong reason to do.

@matthewd @senny @chancancode WDYT?

@rafaelfranca rafaelfranca added this to the 4.0.7 milestone Jun 25, 2014
@egilburg
Copy link
Contributor

Is this a environment-based config? I'd like ability to raise on missing translations in dev/test mode, but not in production.

@rafaelfranca
Copy link
Member

As every config on Rails you can set wherever you want.

@derekprior
Copy link
Contributor

While it is a new configuration option that configuration options enables functionality that existed before the security fix and gives people who can't upgrade to 4.1 a chance to bring this functionality back.

@calebhearth
Copy link
Contributor

I'd also say that this is a regression. If that requires a config option, so be it, but it's been painful not having this behavior available.

rafaelfranca added a commit that referenced this pull request Jun 26, 2014
…nslations

Rails config for raise on missing translations
@rafaelfranca rafaelfranca merged commit 3be7f29 into rails:4-0-stable Jun 26, 2014
@calebhearth
Copy link
Contributor

🎊 🎆

@lukaszx0 lukaszx0 deleted the backport-av-raise-missing-translations branch June 30, 2014 11:39
@lukaszx0
Copy link
Member Author

Thanks @rafaelfranca 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants