-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails config for raise on missing translations #15915
Rails config for raise on missing translations #15915
Conversation
Add a config to setup whether raise exception for missing translation or not. Conflicts: actionview/CHANGELOG.md
Seems like this is an improvement rather than a bug fix. Isn't 4.0 bugfix only? |
Looks like a bugfix to me, in that it corrects a regression. More info: #13196 |
For me, it's very old regression which wasn't fixed. |
When I was working with @kassio on this I thought we should apply to 4-0-stable too because a security fix removed the possibility to raise on missing translation but since it doesn't work on 3.x and it is adding a new configuration I choose to not apply to 4.0. I'm know a lot of people already requested this before so I would consider merging it but I still don't have a strong reason to do. @matthewd @senny @chancancode WDYT? |
Is this a environment-based config? I'd like ability to raise on missing translations in dev/test mode, but not in production. |
As every config on Rails you can set wherever you want. |
While it is a new configuration option that configuration options enables functionality that existed before the security fix and gives people who can't upgrade to 4.1 a chance to bring this functionality back. |
I'd also say that this is a regression. If that requires a config option, so be it, but it's been painful not having this behavior available. |
…nslations Rails config for raise on missing translations
🎊 🎆 |
Thanks @rafaelfranca 👍 |
If I recall correctly, it disappeared from
3-0
and was missing ever since, restored back in4-1
. This PR backports @kassio's commit from4-1
to4-0
.Would be great if we could pack this in
4.0.6
release./cc @tamird