Prefer to pass block when logging. #16099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def unpermitted_parameters(event) | ||
| return unless logger.debug? |
There was a problem hiding this comment.
I think using the block form would be less error prone. Right now, this guard and the following call to debug are directly coupled. If one changes, the other needs to as well. Using the block version, this guard will be done by the Logger. What do you think?
There was a problem hiding this comment.
👍 Should I also standardize this across all the LogSubscribers?
|
@tgxworld looking good. Can you squash the commits? |
|
@senny sure :) Should I leave the commit messages since it'll provide context on why we're making the changes. |
|
@tgxworld sure, they all belong to the same theme though. Only log and build messages when logging is happening. |
The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
|
@senny ok done 😄 |
senny
added a commit
that referenced
this pull request
Jul 18, 2014
Prefer to pass block when logging.
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.