Dump PostgreSQL primary key with custom function as a default. #16127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,6 +117,13 @@ def enable_uuid_ossp!(connection) | |||
| return true if connection.extension_enabled?('uuid-ossp') | |||
|
|
|||
| connection.enable_extension 'uuid-ossp' | |||
| # Create custom PostgreSQL function to generate UUIDs | |||
| # to test dumping tables which columns have defaults with custom functions | |||
| connection.execute <<-SQL | |||
There was a problem hiding this comment.
maybe it better to place it inside the test that use it
|
Squash please |
For example, if use pgcrypto extension in PostgreSQL 9.4 beta 1, where uuid-ossp extension isn't available for moment of writing, and thus to use a gen_random_uuid() method as a primary key default. In this case schema dumper wasn't able to correctly reconstruct create_table statement and lost primary key constraint on schema load. Fixes #16111.
|
I've squashed it few days ago, is there anything I should to do yet? |
matthewd
added a commit
that referenced
this pull request
Jul 14, 2014
Dump PostgreSQL primary key with custom function as a default.
|
Thanks -- there's no notification when it's updated |
|
Thanks, will know about notification absense in future. Can I backport this pull request in 4-1-stable? |
matthewd
added a commit
that referenced
this pull request
Jul 14, 2014
Dump PostgreSQL primary key with custom function as a default. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/adapters/postgresql/uuid_test.rb
|
Done: 136cbca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16111. See it for more information.
For example, if I use pgcrypto extension in PostgreSQL 9.4 beta 1, where uuid-ossp extension isn't available for moment of writing, and thus required to use a gen_random_uuid() method as a primary key default.
In this case schema dumper wasn't able to correctly reconstruct create_table statement and lost primary key constraint on schema load.
If I create migration in PostgreSQL 9.4 beta 1 as:
Schema dumper currently dumps it as this:
Instead of this:
What about to also backport it to 4-1-stable?