Fix json autoload #16148
Merged
Fix json autoload #16148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(In case anyone wonders – the reason |
`Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a delegation that is set up in `active_support/json/encoding`. We cannot simply require that file in `core_ext/object/json` because it would cause a circular dependency problem (see #12203 for background). We should instead rely on AS's autoload to load that file for us on-demand. To trigger autoload correctly, we need to reference the `AS::JSON::Encoding` constant instead of using the delegated version. Fixes #16131.
|
@jeremy @tenderlove @rafaelfranca I'm merging this so that the fix can go out with 4.1.5. I'll take suggestions/feedback if you think the test case can be improved further but that probably shouldn't block the release 😁 |
chancancode
added a commit
that referenced
this pull request
Jul 29, 2014
Fix json autoload Conflicts: activesupport/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requiring the json core_ext, we are relying on AS's autoload to load the
json/encodingfile to avoid a circular dependency. Here we are incorrectly referencing the delegated config which is not yet available until we loadjson/encoding.The fix is pretty straight forward, but adding a regression test for this is tricky. @jeremy wdyt about the test I added here? It works, but have some doubts about it. Do you have better suggestions?
Fixes #16131