Fix SQLite adapter so that it correctly fetches the names of temporary tables. #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
+1, seems fine. |
|
+1 : Makes sense to include, tests work properly, and code looks good. |
|
+1 |
|
sqlite adapter was removed from master in favor of sqlite3 adapter, so I'm closing this pull request. If you still have this issue and want it merged in master please rebase this one with the master branch and reopen it. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQLite adapter currently doesn't query the sqlite_temp_master table, so any temporary tables created are never found. This patch fixes it by performing a UNION on the sqlite_master and sqlite_temp_master tables.