Address ORA-00972: identifier is too long when tested with Oracle #16167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| class Face < ActiveRecord::Base | |||
| belongs_to :man, :inverse_of => :face | |||
| belongs_to :polymorphic_man, :polymorphic => true, :inverse_of => :polymorphic_face | |||
| belongs_to :polymorphic_man_without_inverse, :polymorphic => true | |||
| belongs_to :poly_man_without_inverse, :polymorphic => true | |||
There was a problem hiding this comment.
Probably worth a comment here, so it doesn't get changed back to the more "natural" spelling?
There was a problem hiding this comment.
Thanks for the quick update. I was thinking to change without to wo but it did not satisfy 30 bytes length, Also thinking about to change inverse to invrs but it looked more unclear. As long as it can be 30 byte or less, whichever name is fine for me. If you have some suggestions for alternative, it would be very appreciated.
There was a problem hiding this comment.
I'm happy with this name... I just think we should add a comment to this line, noting that the name needs to be less than 25 characters for Oracle.
yahonda
referenced
this pull request
Jul 14, 2014
…nverse_of prevent bad automatic inverse_of association
by using shorter attribute names.
|
@matthewd Updated with comments, then squashed my commit. |
matthewd
added a commit
that referenced
this pull request
Jul 14, 2014
Address ORA-00972: identifier is too long when tested with Oracle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request address the following error since #15343 has been merged to master.
Because the max identifier length of Oracle is limited to 30 bytes.
This pull request uses shorter name by renaming
polymorphictopolyonly for attribute names which is over 30 bytes.