adding indexes on tables in migration scripts #16258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,9 @@ class CreateOrders < ActiveRecord::Migration | |||
| t.datetime :order_date | |||
| t.timestamps | |||
| end | |||
|
|
|||
| add_index :orders, :customer_id | |||
|
|
|||
There was a problem hiding this comment.
And in all your additions.
|
@mattwarrenrnp can you squash your commits together? |
|
travis failed on some intermittent error there unrelated to the patch.. |
| @@ -109,6 +109,8 @@ class CreateOrders < ActiveRecord::Migration | |||
| t.datetime :order_date | |||
| t.timestamps | |||
| end | |||
|
|
|||
| add_index :orders, :customer_id | |||
There was a problem hiding this comment.
can we use the :index option of belongs_to?
|
@mattwarrenrnp I noticed that most associations are defined with |
missed one migration script in last commit remove some empty lines using the belongs_to index option to be more concise
senny
added a commit
that referenced
this pull request
Jul 25, 2014
adding indexes on tables in migration scripts [ci skip]
|
@mattwarrenrnp thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen several developers new (and old) to rails miss adding indexes to columns in migration scripts. In the vast majority of use cases adding indexes to foreign keys is best practice. As this guide is a top search result I feel that it's important to show best practices rather than a minimum working solution.
With so much magic in Rails, one may expect indexes to be added for you. Having them in the guide serves as a reminder that you need to explicitly add them yourself.