Small Action View Overview guide grammar and readability tweaks #16271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alol
changed the title
|
|
||
|
|
||
| Templates, Partials and Layouts | ||
| ------------------------------- | ||
|
|
||
| As mentioned before, the final HTML output is a composition of three Rails elements: `Templates`, `Partials` and `Layouts`. | ||
| Below is a brief overview of each one of them. | ||
| As mentioned, the final HTML output is composed of three Rails elements: `Templates`, `Partials` and `Layouts`. |
There was a problem hiding this comment.
I don't think "composed of" quite captures the meaning here... to me, the final output is made by the three elements, rather than being made of them.
There was a problem hiding this comment.
Ah, yeah, I see. I can't think of a better way of expressing that than the original, so I'll step back to that.
Many thanks for your feedback!
Some small grammar and readability edits
|
@matthewd – I've made the suggested changes, would you mind taking another look, when you have a chance? 😄 |
vijaydev
added a commit
that referenced
this pull request
Aug 21, 2014
Small Action View Overview guide grammar and readability tweaks
|
Thanks @vijaydev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the Action Controller Overview guide making a few small changes to improve its grammar and readability (I hope!)