Get request should not write to database note added.

[deependersingla]

Get Request should not write to database according to security guideline's note added to Section 3.7 HTTP verb constraint.

[zzak]

"..in Rails doesn't check for CSRF token."

[zzak]

"You should never write to the database from 'GET' requests, for more information see the security guide on CSRF countermeasures."

[deependersingla]

You are right @zzak Thanks for edit. How should I add them or will you do this when merging it?

[arthurnn]

@deependersingla you can fix those statements yourself and git commit --amend in your branch. Also, make sure to add a [skip ci] in the commits message as this is just doc changes.

[deependersingla]

@arthurnn Done deependersingla@4acde5a.

Thanks

[zzak]

@deependersingla Could you squash it to one commit? And don't forget "[ci skip]" in the commit message.

Then I can merge this.

Thank you!

[arthurnn]

This is one way to squash those 2 commits in one.

git reset --soft HEAD~2
git commit -m"Get request should not write to database note added. [skip ci]"
git push -f origin HEAD

[deependersingla]

thanks @arthurnn and @zzak really appreciate your help and support to rails, I am also looking for long time support though I am a beginner.

[deependersingla]

@zzak Done

[zzak]

@deependersingla Thank you!

[deependersingla]

thanks @zzak I am very happy, always wanted to submit something to rails. Hope can do something more in future this is what I am working on now: #16266