Correctly determine if migration is needed. #16349
Merged
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 This is helpful. |
|
Seems your last commit needs a test case. |
|
could you squash the test case and the change in the same commit? |
|
OK, squashed my work down to the initial commit. |
|
There is an extra commit in your branch. Could you remove it? |
|
Removed. @JackDanger, you may want to submit that commit in a separate PR? |
|
@jmcnevin his commit is already on master. |
|
Ahh OK, must have been a wonky rebase on my part. |
This method would assume that if last migration in the migrations directory matched the current schema version, that the database was up to date, but this does not account for new migrations with older timestamps that may be pending.
rafaelfranca
added a commit
that referenced
this pull request
Aug 19, 2014
Correctly determine if migration is needed.
rafaelfranca
added a commit
that referenced
this pull request
Aug 19, 2014
Correctly determine if migration is needed.
rafaelfranca
added a commit
that referenced
this pull request
Aug 19, 2014
Correctly determine if migration is needed.
rafaelfranca
added a commit
that referenced
this pull request
Aug 19, 2014
Correctly determine if migration is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method would assume that if last migration in the migrations directory matched the current schema version, that the database was up to date, but this does not account for new migrations with older timestamps that may be pending.
Our dev team has been running into problems with
ActiveRecord::Migration.maintain_test_schema!not always updating our test databases when two branches containing migrations are merged. We normally rundb:test:preparewhen this happens, but since that task is deprecated, this method probably needs to be smarter.