Add ActiveRecord::Tasks::DatabaseTasks.migrate #16350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -784,6 +784,15 @@ def mtime | |||
| end | |||
| end | |||
|
|
|||
| module MigrateTask#:nodoc: | |||
| def self.perform(target_version, verbose, scope) | |||
There was a problem hiding this comment.
Let's avoid the indirection of having this moduke implementing this logic on the migrate method of the database task.
There was a problem hiding this comment.
I folded it into DatabaseTasks.migrate and you're right that it's way better all in one place. Thanks!
This extracts the logic that was embedded in a Rake task into a static method. Bonus: the first test for `rake db:migrate`
rafaelfranca
added a commit
that referenced
this pull request
Jul 31, 2014
Add ActiveRecord::Tasks::DatabaseTasks.migrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the logic that was embedded in a Rake task into a static method.
Bonus: the first test for
rake db:migrate