Null transaction #16363
Merged
Null transaction #16363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 28, 2015
nathanbertram
pushed a commit
to procore/paranoia
that referenced
this pull request
Aug 16, 2017
Fixes rubysherpas#274 It looks like ActiveRecord refactored the Transaction class hierarchy in a non-backwards-compatible way (rails/rails#16363), which breaks `add_to_transaction` for null transactions (I think it probably qualifies as a bug). The workaround is to not try to use `add_to_transaction` in null transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this discussion #16341 (comment) .
This has only 2 simple commits.
TransactionManagerto the bottom, so we can create a constant with the value being aTransactionsub-class. (the constant needs to be defined prior the TransactionManager definition)NullTransactionas a constant.review @rafaelfranca @chancancode
I have another PR, which will remove the inheritance on the
Transactionclass, but I didnt want to mix with these changes as It would make it WAY harder to follow the diff.