Fix regression on after_commit in nested transactions. #16432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jeremy |
| @@ -201,6 +201,7 @@ def perform_commit | |||
| @state.set_state(:committed) | |||
| @state.parent = parent.state | |||
| connection.release_savepoint | |||
| records.delete_if { |r| parent.add_record(r) } | |||
There was a problem hiding this comment.
This is a bit too clever for my taste :)
Why do we need to delete the records from this array anyway? rollback_records doesn't seem to do that.
But if we have to for some reason, I'd rather do a records.each followed by a records.clear
There was a problem hiding this comment.
we dont need to delete them. You are right too fancy =), will just replace this with a normal .each
after_commit should not run in nested transactions, however they should run once the outermost transaction gets committed. This patch fixes the problem copying the records from the Savepoint to its parent. So the RealTransaction will have all records that needs to run callbacks on it. [fixes rails#16425]
chancancode
added a commit
that referenced
this pull request
Aug 12, 2014
…_trans Fix regression on after_commit in nested transactions.
chancancode
added a commit
that referenced
this pull request
Aug 12, 2014
…_trans Fix regression on after_commit in nested transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after_commit should not run in nested transactions, however they should
run once the outermost transaction gets committed. This patch fixes the
problem copying the records from the
Savepointto its parent. So theRealTransactionwill have all records that needs to run callbacks on it.[fixes #16425]
review @rafaelfranca @chancancode
this should be applied on 4-0-stable too.
I will work on a different fix for master, as the code is different.