Fixed issue w/custom accessors + reserved name + inheritance #16458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where custom accessor methods (such as those generated by `enum`) with the same name as a global method are incorrectly overridden when subclassing. This was partially fixed in 4155431 then broken again by e5f15a8. Fixes rails#16288.
|
cc @matthewd @rafaelfranca @tenderlove @eileencodes @arthurnn for review |
|
Interestingly, we currently re-generate the same attribute methods on each subclass. So, for example, if we have a "posts" table with Event.ancestors # => [Event, GeneratedAttributeMethods(id, title, body), NewsItem, GeneratedAttributeMethods(id, title, body), Post, GeneratedAttributeMethods(id, title, body), AR::Base]After talking to @matthewd and digging some of the git history (cc @jonleighton in case you are still interested), it seems like the intention was to move away from that and only generate them on the base class (the first non-abstract superclass). That's seems like a better long term fix, but this patch preserves the existing behaviour for the time because it seemed safer. |
chancancode
added a commit
that referenced
this pull request
Aug 17, 2014
Fixed issue w/custom accessors + reserved name + inheritance Conflicts: activerecord/CHANGELOG.md
chancancode
added a commit
that referenced
this pull request
Aug 17, 2014
Fixed issue w/custom accessors + reserved name + inheritance Conflicts: activerecord/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where custom accessor methods (such as those generated by
enum) with the same name as a global method are incorrectly overriddenwhen subclassing.
This was partially fixed in 4155431 then broken again by e5f15a8.
Fixes #16288.