Use the method for determining attribute methods rather than duplicating #16505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @senny We could also replace the |
|
@sgrif thanks for bringing this up. Looks good to me. I'm 👍 for using |
I've been trying to reduce the number of places that care about `attributes`, and its existence. We have a method for this check, let's use it instead.
|
@senny Updated. |
senny
added a commit
that referenced
this pull request
Aug 15, 2014
Use the method for determining attribute methods rather than duplicating
|
thank you 💛 |
senny
added a commit
that referenced
this pull request
Aug 15, 2014
Follow up to the discussion on #16505.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to reduce the number of places that care about
attributes, and its existence. We have a method for this check, let'suse it instead.