Fix broken link to Upgrading Ruby on Rails Guide

[jonatack]

in the 4.2 Release Notes [skip ci]

[zzak]

It should be "upgrading_ruby_on_rails.html#upgrading-from-rails-4.1-to-rails-4.2"

http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4.1-to-rails-4.2

[jonatack]

Thanks @zzak, squashed.

[zzak]

@jonatack Thanks!

[chancancode]

@fxn @zzak @robin850 @jonatack Actually, this seems to be a regression in redcarpet or something else the guides generator code. This format was used for all the previous release notes and it as you can see it works on the live site. Any idea what caused this?

In any case, we should probably revert this and fix the real problem. I suspect we there are many other links that expects the same anchors in our guides and elsewhere on the interwebz.

[zzak]

@chancancode Good point! I only checked the one file to make sure the link worked on edgeguides.

[JuanitoFatas]

@chancancode Probably due to my commit: 699babe in this PR #15242. But I need this to make my chinese translations work. I'll look into this.

[fxn]

Back to square one after 597a666.

That commit restores the link in addition to revert the original change.

[zzak]

Revert commits count too!

[robin850]

Sorry if I'm understanding it wrong but actually we are removing non-ASCII characters just to remove special characters (like &, | or *). This is a bit more code but what do you think about:

diff --git a/guides/rails_guides/markdown.rb b/guides/rails_guides/markdown.rb
index b422a80..1703506 100644
--- a/guides/rails_guides/markdown.rb
+++ b/guides/rails_guides/markdown.rb
@@ -47,7 +47,12 @@ module RailsGuides
       end

       def dom_id_text(text)
-        text.downcase.gsub(/\?/, '-questionmark').gsub(/!/, '-bang').gsub(/[^a-z0-9]+/, ' ').strip.gsub(/\s+/, '-')
+        escaped_chars = Regexp.escape('\\/`*_{}[]()#+-.!:,;|&<>^~=\'"')
+
+        text.downcase.gsub(/\?/, '-questionmark')
+                     .gsub(/!/, '-bang')
+                     .gsub(/[#{escaped_chars}]+/, ' ').strip
+                     .gsub(/\s+/, '-')
       end

       def engine

The output folder generate guides with and without this patch will be the same. @JuanitoFatas: Could you please test that in your fork ? If it looks good to you guys, feel free to commit it. :-)

[JuanitoFatas]

@robin850 I was trying to do things like this but thought I may not consider all cases. I'll test it tomorrow and let you know, Thanks!!!!! 👍