[ci skip] Clarify Action Mailer/Active Job usage note #16612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use `deliver_later` now to send the emails and when you decide to start sending the | ||
| email from a background job you'll just have to setup Active Job to use a queueing | ||
| NOTE: Active Job's default behavior is to execute jobs ':inline'. So, you can use | ||
| `deliver_later` now to send emails, and when you later decided to start sending |
There was a problem hiding this comment.
it should be when you later decide 😸
There was a problem hiding this comment.
omg. embarrassing! fixed :)
| backend (Sidekiq, Resque, etc). | ||
|
|
||
| If you want to send the emails right away (from a cronjob for example) just | ||
| call `deliver_now`: | ||
| If you want to send emails right away (from a cronjob for example) just call `deliver_now`: |
There was a problem hiding this comment.
This is a nit-pick but could you please wrap this line around 80 chars ? It looks good to me so far, thanks for your contribution ! :-)
There was a problem hiding this comment.
will do! sorry about that.
zzak
pushed a commit
that referenced
this pull request
Aug 21, 2014
[ci skip] Clarify Action Mailer/Active Job usage note
|
Thanks ! |
|
@robin850 @loganhasson Thank you! <3 <3 <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.