Remove 'if exists' from drop table statement then use table_exists?
#16778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses
ActiveRecord::StatementInvalid: OCIError: ORA-00933: SQL command not properly ended
errors with Oracle database. Since Oracle database does not support 'drop table if exists' statement.One of current test case output is here:
I understand
if exists
is much simpler and supported by SQLite, PostgreSQL and MySQL, I'd like to execute Rails unit tests with Oracle database to keep support compatibility with Rails. I tested this commit does not cause regressions with sqlite, mysql, mysql2 and postgresql adapters.