Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "For not..." to "Do not...". #16804

Merged
merged 1 commit into from
Sep 4, 2014
Merged

Change "For not..." to "Do not...". #16804

merged 1 commit into from
Sep 4, 2014

Conversation

kaleworsley
Copy link
Contributor

Changed the line

For not swallow errors in after_commit/after_rollback callbacks.

to

Do not swallow errors in after_commit/after_rollback callbacks.

rafaelfranca added a commit that referenced this pull request Sep 4, 2014
@rafaelfranca
Merge pull request #16804 from kaleworsley/for_not_to_do_not
181d4f2 
Change "For not..." to "Do not...".
@rafaelfranca rafaelfranca merged commit 181d4f2 into rails:master Sep 4, 2014
@kaleworsley kaleworsley deleted the for_not_to_do_not branch September 4, 2014 21:25
akshay-vishnoi pushed a commit to akshay-vishnoi/rails that referenced this pull request Sep 5, 2014
cover all cases of For not --> Do not, related to rails#16804
8f87a54
guilleiguaran added a commit that referenced this pull request Sep 5, 2014
@guilleiguaran
Merge pull request #16809 from akshay-vishnoi/for_not_to_do_not
9f52f04 
Cover all cases of `For not` --> `Do not`, related to #16804
trungpham pushed a commit to trungpham/rails that referenced this pull request Sep 18, 2014
@trungpham
cover all cases of For not --> Do not, related to rails#16804
85800fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaleworsley @rafaelfranca