Fix problem with tests declared with nonalphanumeric characters in their name #1684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I define my unit tests declaratively and use characters that are not alphanumeric, the Declarative module tries to generate a test method with an invalid name. For example:
test "method's return value" do
something
end
Generates a test method called "s_return_value". This sucks when the tests run (especially in an IDE) because the test name displayed doesn't make any sense. It also leads to some tricky bugs. If I have another test method in the same suite like this:
test "other method's return value" do
something
end
The Declarative module has now blown away the first test method without telling me. Gross.
This change MIME-encodes any nonprintable characters in the test method name, avoiding this issue.