ActiveRecord deprecated finders are broken in 4.2 #16929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should not support the deprecated finders in 4.2 or at least patch the gem to work with 4.2 |
|
@seuros "It will be removed as a dependency in Rails 4.1, but users can manually include it in their Gemfile and it will continue to be maintained until Rails 5." Agree we should fix this from the gem's side if at all feasible, however. |
| @@ -128,7 +128,8 @@ def find(*ids) | |||
| primary_key.nil? || | |||
| default_scopes.any? || | |||
| columns_hash.include?(inheritance_column) || | |||
| ids.first.kind_of?(Array) | |||
| ids.first.kind_of?(Array) || | |||
| ids.first.kind_of?(Symbol) | |||
There was a problem hiding this comment.
Could you documented this code is to support deprecated_finders?
stopdropandrew
force-pushed
the
fix-activerecord-deprecated_finders-find-symbol
branch
from
4f863d2
to
4845497
Compare
Maintain compatibility for: * ActiveRecord::Base#find(:all) * ActiveRecord::Base#find(:first) * ActiveRecord::Base#find(:last)
stopdropandrew
force-pushed
the
fix-activerecord-deprecated_finders-find-symbol
branch
from
4845497
to
6a3626b
Compare
|
Added comment and rebased. |
rafaelfranca
added a commit
that referenced
this pull request
Sep 17, 2014
…_finders-find-symbol ActiveRecord deprecated finders are broken in 4.2
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: rails/activerecord-deprecated_finders#25
Maintain compatibility for:
I've got a solution and pointed a build at it. Viewable at Gemfile-edge @ https://travis-ci.org/kongregate/activerecord-deprecated_finders/builds/35390651.