Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] ActiveSupport CHANGELOG fixes #16948

Merged
merged 1 commit into from
Sep 17, 2014

Conversation

akshay-vishnoi
Copy link
Contributor

  1. spacing issues
  2. spelling correction
  3. grammar correction
  4. Add missing docs

refer #16576
cc @chancancode

also check grammar in line 113 and 299

1. spacing issues
2. spelling correction
3. grammar correction
4. Add missing docs
rafaelfranca added a commit that referenced this pull request Sep 17, 2014
[ci skip] ActiveSupport CHANGELOG fixes
@rafaelfranca rafaelfranca merged commit 026289e into rails:master Sep 17, 2014
@akshay-vishnoi
Copy link
Contributor Author

Please check grammar in line 113 and 299.

@rafaelfranca
Copy link
Member

I think 113 is wrong, not sure about 299. What you saw wrong there?

@akshay-vishnoi
Copy link
Contributor Author

it's given part is not clear.

`HashWithIndifferentAccess` better respects `#to_hash` on objects it's given.

@akshay-vishnoi
Copy link
Contributor Author

Also please suggest correction for 113, i will add them.

@rafaelfranca
Copy link
Member

Maybe:

Since ActiveSupport::Notifications only instrument items when there are attached subscriber we don't need to disable instrumentation.

and

HashWithIndifferentAccess better respects #to_hash on objects it receives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants