Standardize on Rails.application [ci skip]
#16979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the style settled on in most of the templates.
| @@ -73,7 +73,7 @@ | |||
| namespace: my_app_development | |||
|
|
|||
| # config/production.rb | |||
| MyApp::Application.configure do | |||
| Rails.application.configure do | |||
There was a problem hiding this comment.
I don't think we should change the CHANGELOG.
There was a problem hiding this comment.
there was another instance i didn't change because it was in the 3.0 release, but this one is unreleased, so i thought it'd be ok for consistency's sake. should i remove this change?
senny
added a commit
that referenced
this pull request
Sep 21, 2014
Standardize on `Rails.application` [ci skip]
|
@tamird thank you 💛 as the CHANGELOG is not released it's fine. I changed back the occurrences in the upgrading guide. They were both from 3.x -> 4.0 which did not have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.