Turn off mysql2's eager-casting #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues later. This should help performance for tables with complex types like DATETIME, TIMESTAMP
|
Forgot to mention, the AR adapter in the 0.2.8 release has this change already so people should see similar performance gains with versions of ActiveRecord prior to 3.1 |
josevalim
added a commit
that referenced
this pull request
Jun 14, 2011
Turn off mysql2's eager-casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of mysql2 0.2.8 and 0.3.3, eager-casting down in C can be disabled.
This should help performance by allowing ActiveRecord to lazily cast row values upon access (like the mysql adapter is doing). My rudimentary benchmarks show it performing about on-par with the mysql adapter, but has the added benefit of being fully thread-safe, even in Ruby 1.8 (and 1.9 obviously).