Use include_blank value as option label #17064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| include_blank = '' | ||
| end | ||
|
|
||
| option_tags = content_tag(:option, '', :value => include_blank).safe_concat(option_tags) |
There was a problem hiding this comment.
The value should be always empty string. Only the text that can be the include_blank value
|
@rafaelfranca Thanks for pointing that out. I fixed it. |
|
Great! Now we will need a test to assert this behaviour and avoid regressions. |
|
I've added a test for it. |
|
@rafaelfranca Is there still something wrong? Or can this be merged? |
|
LGTM, before merging, can you squash all your commits in 1. so would make it easier to track back in history. thanks |
Update select_tag to reflect documentation and behave the same as form builder select. If the value of include_blank is not boolean true, use that value as the option label.
|
Great! In my branch I've force-pushed a merged commit. The Github interface doesn't seem to recognize this though. |
|
@arthurnn @rafaelfranca Is this correct now? Can it be merged? |
rafaelfranca
added a commit
that referenced
this pull request
Oct 25, 2014
Use include_blank value as option label
rafaelfranca
added a commit
that referenced
this pull request
Oct 25, 2014
Use include_blank value as option label
rafaelfranca
added a commit
that referenced
this pull request
Oct 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update select_tag to reflect documentation and behave the same as form builder select. If the value of include_blank is not boolean true, use that value as the option label.