Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-skip] Update Active Job API documentation #17068

Merged
merged 1 commit into from
Oct 2, 2014
Merged

[ci-skip] Update Active Job API documentation #17068

merged 1 commit into from
Oct 2, 2014

Conversation

xlgmokha
Copy link
Contributor

Update Active Job API documentation as per issue #16576.

/cc @chancancode I hope this helps!

#
# == Callbacks
#
# Active Jobs supports a set of Callbacks::ClassMethods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callbacks shouldn't here i think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove.

@xlgmokha xlgmokha changed the title Update Active Job API documentation [ci-skip] Update Active Job API documentation Sep 26, 2014
# == Exceptions
#
# * DeserializationError - Error class for deserialization errors.
# errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks @cristianbica

@seuros seuros added this to the 4.2.0 milestone Sep 26, 2014
@xlgmokha
Copy link
Contributor Author

xlgmokha commented Oct 2, 2014

Is there anything else I should change on this @chancancode?

@seuros
Copy link
Member

seuros commented Oct 2, 2014

squash your commits please.

This adds documentation for the Active Job API. It includes
documentation on how to configure the queue_adapter, and how to create
new jobs. It adds links to the various other sections of the Active Job
documentation.
@xlgmokha
Copy link
Contributor Author

xlgmokha commented Oct 2, 2014

@seuros Done! 😄

#
# More information can be found in ActiveJob::Core::ClassMethods#set
#
# == Exceptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzak @rafaelfranca , should we document exceptions here ?

seuros added a commit that referenced this pull request Oct 2, 2014
[ci-skip] Update Active Job API documentation
@seuros seuros merged commit 4cd57a8 into rails:master Oct 2, 2014
@seuros
Copy link
Member

seuros commented Oct 2, 2014

@mokhan Thank you

@xlgmokha
Copy link
Contributor Author

xlgmokha commented Oct 2, 2014

@seuros You're welcome. Please let me know if there is anything else I can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants