titleizing the New Link #17109
Merged
titleizing the New Link #17109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,4 +28,4 @@ | |||
|
|
|||
| <br> | |||
|
|
|||
| <%%= link_to 'New <%= human_name %>', new_<%= singular_table_name %>_path %> | |||
| <%%= link_to 'New <%= human_name.titleize %>', new_<%= singular_table_name %>_path %> | |||
There was a problem hiding this comment.
considering we don't use human_name anywhere else we should change it to singular_table_name.titleize.
|
I believe we already had this same pull request and we rejected because it made the name looks more artificial, not for humans. Thank you for the pull request. |
|
Just saw we are already using |
|
@rafaelfranca shall we keep it consistent? |
|
@thejamespinto yes, please change for what @senny suggested and I'll merge. |
|
@rafaelfranca there we go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.