Add an activerecord relation blacklisted array method #17128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this method is delegted to the array right? If so I believe it make sense. Which kind of problems it can bring? |
|
like > animals = ["mouse", "cow", "tiger", "rabbit", "dragon"]
=> ["mouse", "cow", "tiger", "rabbit", "dragon"]
> animals[3, 2] = 'dragon'
=> "dragon"
> animals
=> ["mouse", "cow", "tiger", "dragon"]So I think this blacklist needs to include |
|
|
|
I see. I think I don't see any problem with So we need to choose
or
|
|
Since |
sgrif
added a commit
that referenced
this pull request
Nov 23, 2015
As was pointed out by #17128, our blacklist of mutation methods was non-exhaustive (and would need to be kept up to date with each new version of Ruby). Now that `Relation` includes `Enumerable`, the number of methods that we actually need to delegate are pretty small. As such, we can change to explicitly delegating the few non-mutation related methods that `Array` has which aren't on `Enumerable`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:[]=is destructive method.And this is not used in ActiveRecord::Relation.
It's a nonsense.