Rename default_form_builder to avoid collision #17138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Configuring Action View guides say the following:
Unfortunately, when you set
config.action_view.default_form_builder
as a string, it is set as a class-level attr_accessor on ActionView::Base. Then line 1191 on master attempts to call an internal method to constantize this string, but instead, it receives thedefault_form_builder
cattr_accessor as a string and attempts to callnew
on it on the subsequent line.This problem only appears when setting this configuration before the file is required, and quite honestly, I couldn't discern how to write a test for the case. But as it's only a naming collision, it seemed innocuous enough to submit as a PR.
Thoughts?