--skip-gems doesn't skip gems placed in development group

[fnando]

I tried using the --skip-gems and notice that some gems aren't skipped.

$ rails new foo --skip-test-unit --skip-javascript --skip-bundle --skip-gems jbuilder sdoc byebug web-console spring

Right now, only jbuilder and sdoc are skipped; byebug web-console and spring are still present.

Here's the generated Gemfile:

source 'https://rubygems.org'


# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '4.2.0.beta2'
# Use sqlite3 as the database for Active Record
gem 'sqlite3'
# Use SCSS for stylesheets
gem 'sass-rails', '~> 5.0.0.beta1'
# Use Uglifier as compressor for JavaScript assets
gem 'uglifier', '>= 1.3.0'
# Use ActiveModel has_secure_password
# gem 'bcrypt', '~> 3.1.7'

# Use Unicorn as the app server
# gem 'unicorn'

# Use Capistrano for deployment
# gem 'capistrano-rails', group: :development

group :development, :test do
  # Call 'debugger' anywhere in the code to stop execution and get a debugger console
  gem 'byebug'

  # Access an IRB console on exception pages or by using <%= console %> in views
  gem 'web-console', '~> 2.0.0.beta4'

  # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
  gem 'spring'
end

The expected behavior would be omitting the group entirely, since all gems from that group have been specified. And even spring having its own flag --skip-spring, it should respect the --skip-gems.

Tested version: Rails 4.2.0.beta2

[rafaelfranca]

In fact I saw this problem when the Gemfile was modified to include groups. I have a patch to fix this problem but I'll need to check with the team if we are going to keep this feature.

[jrochkind]

I was really looking forward to being able to skip turbolinks, which I think is a popular desire; I hope you don't roll back the entire skip_gems feature, since that is what will allow skipping of turbolinks. (A separate --skip-turbolinks option in another much earlier pull request was rejected because it would be covered by the generic --skip-gems feature).

I think it's probably acceptable if the new --skip-gems feature doesn't work for development gems, at least it works for production gems, and will be very welcome where it does work (better than not existing for any of them!).

[fnando]

@jrochkind I don't think Rails should ship a half-baked solution. It must either work for all gems or be removed from next release until it fully works.

[jrochkind]

thank you for adding back --skip-turbolinks with the removal of skip-gems!