Patch for #1458 - [3.1.0.rc1] App plugins initialized before engines and plugins inside engines #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines
and plugins inside engines
It seems that plugins inside a Rails 3.1 application proper (i.e. in
/vendor/plugins) are initialized before engines and plugins inside
engines.
After some debugging, I found the culprit in
Rails::Application::Railties#all:
def all(&block)
@ALL ||= railties + engines + super
@all.each(&block) if block
@ALL
end
The call to super here implicitly passes the &block argument, which
has the unfortunate side-effect of adding the plugin initializers
first (in front of other railties and engines) in the case of
Rails::Engine#initializers:
def initializers
initializers = []
railties.all { |r| initializers += r.initializers }
initializers += super
initializers
end
The solution here is to replace the super call with a call
to #plugins.
josevalim
added a commit
that referenced
this pull request
Jun 16, 2011
…ing_patch Patch for #1458 - [3.1.0.rc1] App plugins initialized before engines and plugins inside engines
|
Can you send the same pull request for master please? |
|
Patch for master submitted as #1737 |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
… was canceled or before_update was canceled Signed-off-by: Michael Koziarski <michael@koziarski.com> [rails#1735 state:committed]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for #1458 - [3.1.0.rc1] App plugins initialized before engines and plugins inside engines
It seems that plugins inside a Rails 3.1 application proper (i.e. in /vendor/plugins) are initialized before engines and plugins inside engines.
After some debugging, I found the culprit in Rails::Application::Railties#all:
The call to super here implicitly passes the &block argument, which has the unfortunate side-effect of adding the plugin initializers first (in front of other railties and engines) in the case of Rails::Engine#initializers:
The solution here is to replace the super call with a call to #plugins.