improved try documentation #17378
Closed
improved try documentation #17378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- better `if` example - Added chaining example to the try method description - Documented the `respond_to?` check to the try method description - Clearer wording to explain that argument error is raised on argument mismatch to responding method, rather than to non-responding method (which is handled without exception by `try`) - `.any?` is more precise than `! .blank?` - Don't need to use `try` on `children` as (for regular associations) they will always be a collection or array that responds to `first` - Fix typos/grammar
| # | ||
| # +try+ will also return +nil+ if the receiver does not respond to the method: | ||
| # | ||
| # @person.try(:non_existing_method) |
zzak
pushed a commit
to zzak/rails
that referenced
this pull request
Oct 24, 2014
|
Merged manually in df1dda8 |
| # | ||
| # With +try+ | ||
| # @person.try(:children).try(:first).try(:name) | ||
| # @person.try(:children).first.try(:name) |
There was a problem hiding this comment.
@egilburg why was this changed?
There was a problem hiding this comment.
My bad I misread the code :-( I'll make a fix pr soon.
There was a problem hiding this comment.
oops nvm I see you already reverted it, thanks!
There was a problem hiding this comment.
@chancancode @egilburg I missed this sorry, thanks for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifexamplerespond_to?check to the try method descriptiontry).any?is more precise than! .blank?tryonchildrenas (for regular associations) they will always be a collection or array that responds tofirst