Rely on through table name in has_many fixtures #17426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixtures code always builds join table names via the association's
join_table
method, which will usederive_join_table
to build the table name via convention. But in the event a join table was created with a different table name, this will fall down. Using thethrough_association#table_name
makes an affordance for both of these cases.I think the existing code works from for the
ReflectionProxy
but should be overridden for theHasManyThroughProxy
to handle if the table name is either overridden in the model or created with a different table name.