Add a section about job testing #17476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ------------ | ||
|
|
||
| Since your custom jobs can be queued at different levels inside your application | ||
| (e.g. inside your models or controllers), you'll need to test both jobs themselves |
There was a problem hiding this comment.
I think "different levels inside your application" is enough, we don't need the examples.
|
@sgrif : Updated ; thanks for the review ! :-) |
| | -------------------------------------- | ------- | | ||
| | `assert_enqueued_jobs(number)` | Asserts that the number of enqueued jobs matches the given number. | | ||
| | `assert_performed_jobs(number)` | Asserts that the number of performed jobs matches the given number. | | ||
| | `assert_no_enqueued_jobs { ... }` | Asserts that no jobs have been enqueued within the block. | |
There was a problem hiding this comment.
For consistency with assert_no_performed_jobs and because passing a block is optional, should we rewrite the purpose as Asserts that no jobs have been enqueued?
* Cover lower level job testing (assertions about the execution of the job itself). * Add a table with the custom assertions provided by Active Job's `TestHelper` module. * Add an example testing job queuing inside a model
|
@robin850 since you are on the issues team, I'll assign this back to you. You can solicit feedback directly from those who might be able to help you and merge this when it's ready |
robin850
added a commit
that referenced
this pull request
Nov 8, 2014
Add a section about job testing [ci skip]
|
Thanks you very much everyone ! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is just a follow up to #16921 addressing the different comments. This part makes the distinction between normal job testing and asserting that a job get enqueued/performed inside other components like models.
Also it makes the assumption that
ActiveJob::TestHelper's methods are available directly fromActiveSupport::TestCaseas it should normally be the case (c.f. #17475).Cross-refs #16576.
Have a nice day.