Move DebugExceptions#traces_from_wrapper to ExceptionWrapper #17480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| appplication_trace_with_ids << trace_with_id if application_trace.include?(trace) | ||
| framework_trace_with_ids << trace_with_id if framework_trace.include?(trace) | ||
| full_trace_with_ids << trace_with_id | ||
| end if full_trace |
There was a problem hiding this comment.
I prefer to keep if with block version.
There was a problem hiding this comment.
Fair point, changed it only for consistency with #source_extract.
There was a problem hiding this comment.
Change both. It is easier to see that there is a conditional when it is on the beginning of the line.
ActionDispatch::ExceptionWrapper seems to be the more natural place for this method to live in.
gsamokovarov
force-pushed
the
exception-wrapper-traces
branch
from
e812334
to
c7f2ee2
Compare
rafaelfranca
added a commit
that referenced
this pull request
Nov 4, 2014
Move DebugExceptions#traces_from_wrapper to ExceptionWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionDispatch::ExceptionWrapperseems to be the more natural place forthis method to live in. Pinging @bronzle as he recently fixed an issue in this
method.