[Enh] Made the ActiveModel::Dirty#clear_attribute_changes method public #17545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -186,6 +186,11 @@ def restore_attributes(attributes = changed) | |||
| attributes.each { |attr| restore_attribute! attr } | |||
| end | |||
|
|
|||
| # Remove changes information for the provided attributes. | |||
| def clear_attribute_changes(attributes) | |||
There was a problem hiding this comment.
We should keep it with private visibility and just add a # :doc: comment after the ) like we did with changes_applied
There was a problem hiding this comment.
I've amended the commit just adding the # :doc: tag as suggested.
…e_changes method In Rails 4.2 it is impossible to define a custom default value for a model's attribute without making it appear as _changed?, especially when the model is first initialized. Making this method publicly visible will allow such a behaviour, without the need to use private APIs.
marzapower
force-pushed
the
dirty_public_api
branch
from
43ebcf4
to
eb05774
Compare
|
Awesome! Thank you |
rafaelfranca
added a commit
that referenced
this pull request
Nov 6, 2014
[Enh] Made the ActiveModel::Dirty#clear_attribute_changes method public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 4.2 it is impossible to define a custom default value for a model's
attribute without making it appear as _changed?, especially when the model
is first initialized. Making this method public will allow such a behaviour,
without the need to use private APIs.