Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Table#name accessor like TableDefinition#name #17580

Merged
merged 1 commit into from
Nov 11, 2014

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Nov 10, 2014

we have a gem that dynamically creates tables (based on date), but passes the Table object on to the client for further manipulating the schema. it's useful for that client to be able to access the dynamic name. I thought it could looking at the docs for TableDefinition, until I realized that change_table creates a Table, not a TableDefinition

@egilburg
Copy link
Contributor

If you want this to be public API, should add a spec for Table#name

@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 10, 2014

@egilburg done

@senny senny merged commit 76e7305 into rails:master Nov 11, 2014
senny added a commit that referenced this pull request Nov 11, 2014
add a Table#name accessor like TableDefinition#name
@senny
Copy link
Member

senny commented Nov 11, 2014

@ccutrer thank you 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants