Fix default options argument on ActiveRecord::ConnectionAdaptors::Table#column_exists? #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnectionAdapters::Table#column_exists? from nil to an empty Hash {}.
That method calls through to ActiveRecord::ConnectionAdapters::SchemaStatements##column_exists? expects options to be a Hash.
When options was nil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options.
josevalim
added a commit
that referenced
this pull request
Jun 19, 2011
…ns_hash Fix default options argument on ActiveRecord::ConnectionAdaptors::Table#column_exists?
|
Could you please provide a pull request for 3-1-stable? |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
…1763 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default value for the
optionsargument onActiveRecord::ConnectionAdapters::Table#column_exists?fromnilto an empty Hash{}.That method calls through to
ActiveRecord::ConnectionAdapters::SchemaStatements#column_exists?which expectsoptionsto be a Hash.When
optionswasnil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options.