Add option to omit creating an instance reader method on class_attribute #1765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make
class_attribute
a little more backward compatible with the now-removedclass_inheritable_accessor
, I've added the ability to disable the instance reader method.Here's an example case of where it's needed:
https://gist.github.com/1033533
TL;DR: You can't override the reader method if the module extends ActiveSupport::Concern because of the order that things get mixed-in.
We're struggling to get Carrierwave running on Rails master as we remove uses of
class_inheritable_attribute
-- if there's any way this can be merged into 3-0-stable and 3-1-stable, that would help a ton. Thanks.