Fixed a bug where AR::RecordNotSaved loses the given error message #17808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 3e30c5d, it started ignoring the given error message. This commit changes the behavior of AR::RecordNotSaved#initialize so that it no longer loses the given error message.
|
yeah.. this make sense 👍 |
| @@ -54,9 +54,9 @@ class RecordNotFound < ActiveRecordError | |||
| class RecordNotSaved < ActiveRecordError | |||
| attr_reader :record | |||
|
|
|||
| def initialize(record) | |||
| def initialize(message, record = nil) | |||
There was a problem hiding this comment.
Is there any place we don't pass record?
There was a problem hiding this comment.
Just saw that there are. I think we should always pass record
There was a problem hiding this comment.
It turns out that there are several questions around whether or not we should always include record:
- Sometimes,
AR::RecordNotSavedis raised before initializing an AR object. Do we need to initialize and passrecordeven in such a case? recordcould be plural if it's raised fromcollection_association.rb. Is it ok forrecordto be plural at times? Also, do we want to include all the target records or only unsaved records?
I guess we should focus on a bug fix in this pull request as @arthurnn suggested earlier, and we can discuss the questions above after that.
@arthurnn @rafaelfranca what do you think?
There was a problem hiding this comment.
Hmm, I guess it is fine as it is now.
rafaelfranca
added a commit
that referenced
this pull request
Nov 28, 2014
…loses-error-message Fixed a bug where AR::RecordNotSaved loses the given error message
yuki24
deleted the
fix-bug-where-record-not-saved-loses-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was extracted from #17806 that had an improvement and a bug fix. This is the bug fix.
Since 3e30c5d,
AR::RecordNotSavedstarted ignoring the given error message. This commit changesAR::RecordNotSaved#initializeto not ignore the given error message.Doing
create_or_update || raise(RecordNotSaved.new(nil, self))inActiveRecord::Persistencelooks weird, but I'll send another pull request to improve it as soon as this one is merged.cc @arthurnn