Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value extracted from negative integers for PostgreSQL. #17863

Merged
merged 1 commit into from
Dec 1, 2014
Merged

Fix value extracted from negative integers for PostgreSQL. #17863

merged 1 commit into from
Dec 1, 2014

Conversation

tgxworld
Copy link
Contributor

@tgxworld tgxworld commented Dec 1, 2014

Fixes: #17856.

@tgxworld
Copy link
Contributor Author

tgxworld commented Dec 1, 2014

@sgrif @senny The regular expression was capturing the wrong group. I couldn't determine the right place to write the tests. Perhaps you guys might have a better idea.

@senny
Copy link
Member

senny commented Dec 1, 2014

I'd add the test here

@tgxworld tgxworld force-pushed the fix_extracated_default_value_for_negative_integers branch from 4b42f7d to 0270363 Compare December 1, 2014 14:00
@tgxworld
Copy link
Contributor Author

tgxworld commented Dec 1, 2014

@senny I came across DefaultTest. I've added the test case. Could you see if it might be a better place?

rafaelfranca added a commit that referenced this pull request Dec 1, 2014
@rafaelfranca
Merge pull request #17863 from tgxworld/fix_extracated_default_value_…
8cad52c 
…for_negative_integers

Fix value extracted from negative integers for PostgreSQL.
@rafaelfranca rafaelfranca merged commit 8cad52c into rails:master Dec 1, 2014
rafaelfranca added a commit that referenced this pull request Dec 1, 2014
@rafaelfranca
Merge pull request #17863 from tgxworld/fix_extracated_default_value_…
12dda45 
…for_negative_integers

Fix value extracted from negative integers for PostgreSQL.
@rafaelfranca rafaelfranca mentioned this pull request Dec 1, 2014
Closed
senny added a commit that referenced this pull request Dec 1, 2014
@senny
tests, use public API to verify default parsing. #17863, #17856
cd2596f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validates Numericality Fails with Postgresql in Rails 4.2.0.rc1
3 participants
@tgxworld @senny @rafaelfranca