Silence Minitest for plugin tests. #17867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,7 @@ | |||
| require "rails/test_help" | |||
|
|
|||
| Rails.backtrace_cleaner.remove_silencers! | |||
| Rails.backtrace_cleaner.add_silencer { |line| line =~ /lib\/minitest/ } | |||
There was a problem hiding this comment.
Can we add Minitest::BacktraceFilter?
tgxworld
force-pushed
the
silence_minitest_plugins
branch
2 times, most recently
from
ec98baf
to
8b1afe1
Compare
Fixes rails#17340. Use Minitest::BacktraceFilter instead of removing all silencers. This will allow the backtrace for all libraries in the plugin to be shown while removing noise generated by Minitest's backtrace.
tgxworld
force-pushed
the
silence_minitest_plugins
branch
from
8b1afe1
to
106db0b
Compare
|
@rafaelfranca I've updated the pull request to use |
|
The only way is checking the class of |
rafaelfranca
added a commit
that referenced
this pull request
Dec 2, 2014
Silence Minitest for plugin tests.
rafaelfranca
added a commit
that referenced
this pull request
Dec 2, 2014
Silence Minitest for plugin tests.
rafaelfranca
added a commit
that referenced
this pull request
Dec 2, 2014
Silence Minitest for plugin tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17340.
Rails::BacktraceCleaner's silencers are removed to obtain the full backtrace for all libraries included in the plugin which can be helpful when debugging errors. However, we will silence traces for Minitest as it adds noise to the backtrace.
cc/ @rafaelfranca @chancancode