Fix options overwritten by super #17975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,11 +6,12 @@ module Tags # :nodoc: | |||
| class TextField < Base # :nodoc: | |||
| include Placeholderable | |||
|
|
|||
| def render | |||
| def render(&block) | |||
There was a problem hiding this comment.
Don't need (&block) (it's slower than not having it here) if just using block_given?
There was a problem hiding this comment.
@egilburg cool, i'll do it
merongivian
force-pushed
the
add_test_for_search_field
branch
from
d56c636
to
98d10d7
Compare
|
It is hard to tell what is the fix here since we also have a refactoring. Why it was not working? |
|
Ok, got it. When we call super we reset the options argument with |
|
Could you change your commit message to match the code change? |
merongivian
force-pushed
the
add_test_for_search_field
branch
from
98d10d7
to
112274e
Compare
merongivian
changed the title
|
@rafaelfranca done |
rafaelfranca
added a commit
that referenced
this pull request
Dec 9, 2014
Fix options overwritten by super
rafaelfranca
added a commit
that referenced
this pull request
Dec 9, 2014
Fix options overwritten by super
|
Thank you |
rafaelfranca
added a commit
that referenced
this pull request
Dec 9, 2014
Fix options overwritten by super Conflicts: actionpack/lib/action_view/helpers/tags/text_field.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_field helper had no test for the onsearch option, an indeed it was not working, this pr fix this