Ensure append_info_to_payload is called even if an exception is raised. #17978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we also need the tests from #14903 |
kommen
force-pushed
the
fixed-pr-14903
branch
from
fcbe85c
to
0b904c2
Compare
|
@arthurnn done. The build failure in the ruby-head,GEM=railties vm looks like an unrelated ruby crash to me. |
|
@kommen we also need a changelog entry for this fix. |
See: * rails#14903 * roidrage/lograge#37 Some code by mxrguspxrt from rails#14903.
kommen
force-pushed
the
fixed-pr-14903
branch
from
0b904c2
to
2fde159
Compare
|
@arthurnn Added the changelog. |
rafaelfranca
added a commit
that referenced
this pull request
Jan 2, 2015
Ensure append_info_to_payload is called even if an exception is raised. Conflicts: actionpack/CHANGELOG.md
rafaelfranca
added a commit
that referenced
this pull request
Jan 2, 2015
Ensure append_info_to_payload is called even if an exception is raised. Conflicts: actionpack/CHANGELOG.md
rafaelfranca
added a commit
that referenced
this pull request
Jan 2, 2015
Ensure append_info_to_payload is called even if an exception is raised. Conflicts: actionpack/CHANGELOG.md Conflicts: actionpack/CHANGELOG.md
sgrif
added a commit
that referenced
this pull request
Jun 7, 2016
This test was broken by f650e03. It was added by #17978, and is adequately tested elsewhere. The reason that this breaks is that `Controller#process` is not going to set a new response object, and we now terminate in callbacks if the response has been sent. The only reason that this test was calling `get` in the first place was because the controller under test blows up if `request` was `nil`. The point being that the failure is invalid, and I don't think we need to fix the test in this location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #14903 seems to be stalled, this is my take.
cc @arthurnn @matthewd
See: