Add 'require' for Hash#with_indifferent_access to active_job/arguments.rb #18119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveJob::Arguments uses Hash#with_indifferent_access. But, activejob gem does not require Hash extension library. When we use activejob as standalone, we need extra require statement. This is unhandy. This commit fixes it.
|
👍 |
sgrif
added a commit
that referenced
this pull request
Dec 21, 2014
…_activejob Add 'require' for Hash#with_indifferent_access to active_job/arguments.rb
carlosantoniodasilva
pushed a commit
to carlosantoniodasilva/rails
that referenced
this pull request
Dec 21, 2014
…sh_to_activejob Add 'require' for Hash#with_indifferent_access to active_job/arguments.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveJob::Argumentsuses Hash#with_indifferent_access.But, activejob gem does not require Hash extension library.
When we use activejob as standalone,
we need extra require statement. This is unhandy.
This commit fixes it.