Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in nodoc #18163

Merged
merged 1 commit into from
Dec 23, 2014
Merged

fix typo in nodoc #18163

merged 1 commit into from
Dec 23, 2014

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented Dec 23, 2014

No description provided.

@arunagw
Copy link
Member

arunagw commented Dec 23, 2014

Can we fix same typos in this PR from other parts of code?

@arunagw
Copy link
Member

arunagw commented Dec 23, 2014

And will be good if you add [ci skip] in doc commits

senny added a commit that referenced this pull request Dec 23, 2014
@senny
Merge pull request #18163 from y-yagi/fix_nodoc_typo
b9bc49e 
fix typo in nodoc [ci skip]
@senny senny merged commit 2a110fc into rails:master Dec 23, 2014
senny added a commit that referenced this pull request Dec 23, 2014
@senny
Merge pull request #18163 from y-yagi/fix_nodoc_typo
ced687f 
fix typo in nodoc [ci skip]
@senny
Copy link
Member

senny commented Dec 23, 2014

according to a quick git grep this should be the only occurrence left.

@y-yagi @arthurnn thanks guys 💛

@y-yagi
Copy link
Member Author

y-yagi commented Dec 23, 2014

Thanks!

@y-yagi y-yagi deleted the fix_nodoc_typo branch December 23, 2014 13:08
@arthurnn
Copy link
Member

me ?!? didnt do anything . =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@y-yagi @arunagw @senny @arthurnn