Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails::Application#secrets should be documented. #18170

Merged
merged 1 commit into from
Dec 23, 2014
Merged

Rails::Application#secrets should be documented. #18170

merged 1 commit into from
Dec 23, 2014

Conversation

tgxworld
Copy link
Contributor

@sgrif sgrif merged commit 2f7b72b into rails:master Dec 23, 2014
sgrif added a commit that referenced this pull request Dec 23, 2014
@sgrif
Merge pull request #18170 from tgxworld/add_docs_for_rails_applicatio…
a0e3461 
…n_secrets

[ci skip]
@zzak
Copy link
Member

zzak commented Dec 23, 2014

Is this meant to be public?

sgrif added a commit that referenced this pull request Dec 23, 2014
@sgrif
Merge pull request #18170 from tgxworld/add_docs_for_rails_applicatio…
e1114b3 
…n_secrets

[ci skip]
@sgrif
Copy link
Contributor

sgrif commented Dec 23, 2014

Yes, it's mentioned directly in the release notes for 4.1

sgrif added a commit that referenced this pull request Dec 23, 2014
@sgrif
Merge pull request #18170 from tgxworld/add_docs_for_rails_applicatio…
b0199b8 
…n_secrets

[ci skip]
@zzak
Copy link
Member

zzak commented Dec 23, 2014

@sgrif thanks! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgxworld @zzak @sgrif