-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing time zone definitions for Russian Federation #18489
Conversation
cc @pixeltrix |
@Envek the mappings list is not meant to be an exhaustive list but I'm happy for the correction to Volgograd to be merged. The list is for broad worldwide audience but if you need all possible timezones I suggest rolling your own UX because present a massive drop drown isn't a great experience. |
Also sync Russian Federation time zones with `zone.tab` file from tzdata version 2014j.
OK, removed entries that duplicated existing ones with same UTC offset. But I think entries for Kaliningrad, Samara and Srednekolymsk should be added as there is currently no russian time zones with that offsets are present in mapping. So, with this PR merged, list of russian time zones will be as follows:
For better UX I already created initializer like that: https://gist.github.com/Envek/cda8a367764dc2cacbc0 |
Add missing time zone definitions for Russian Federation
Okay, I can understand that - thanks for the PR 👍 |
Thanks for review! Can it be also backported to 4.2? |
Also synced comments with UTC offsets for russian timezones with present timezones.
Also updated comments with UTC offsets for russian timezones to be in sync with present timezones (in files with such comments).
Today I've noticed that Rails' time zone mapping is missing next russian time zones completely:
Also I noticed that currently mapping points Volgograd to
Europe/Moscow
but inzones.tab
from current tzdata (2014j) there is explicitEurope/Volgograd
timezone exists. Changed it.And last thing: I added mapping for all russian timezones from tzdata (such that Simferopol, Novokuznetsk, and Chita), but all of them duplicates main timezones (Moscow, Novosibirsk, and Irkutsk respectively), and these entries in
zones.tab
looks actual. Please tell me should I include such entries in this PR or not.For more info see file
zones.tab
from tzdata, rows 329 to 349 and Wikipedia article about time in Russia. Please note that there were two large time zone changes in last years in Russia.