Allow comparison on model objects - Closes #1858 #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to return nil when the |
|
@dmathieu as far as I know the primary key does not have to be named "id". may be better use #to_key defined in activemodel (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key)? |
|
Thank you, I've taken both of your comments into account. |
tenderlove
added a commit
that referenced
this pull request
Jun 28, 2011
Allow comparison on model objects - Closes #1858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveRecord object can't be sorted because they can't be compared, as reported in #1858.
This fixes it.
It does the comparison on the object's id, because that's the only field which will be available anyway in all models.
If required to sort on an other field, it should be provided in the block option of the sort method.